Refactor: use COM API for windows firewall rules#21
Merged
FN-FAL113 merged 6 commits intoMar 31, 2026
Annotations
19 warnings
|
ServerPickerX.Tests/ViewModels/MainWindowViewModelTest.cs#L279
Do not use Assert.True() to check for substrings. Use Assert.Contains instead. (https://xunit.net/xunit.analyzers/rules/xUnit2009)
|
|
ServerPickerX.Tests/ViewModels/MainWindowViewModelTest.cs#L501
Possible null reference return.
|
|
ServerPickerX.Tests/ViewModels/MainWindowViewModelTest.cs#L434
Possible null reference argument for parameter 'value' in 'void Assert.Empty(string value)'.
|
|
ServerPickerX.Tests/ViewModels/MainWindowViewModelTest.cs#L279
Dereference of a possibly null reference.
|
|
ServerPickerX.Tests/ViewModels/MainWindowViewModelTest.cs#L275
Possible null reference argument for parameter 'value' in 'void Assert.Empty(string value)'.
|
|
ServerPickerX.Tests/ViewModels/MainWindowViewModelTest.cs#L217
Possible null reference argument for parameter 'value' in 'void Assert.Empty(string value)'.
|
|
ServerPickerX.Tests/Services/DependencyInjection/ServiceLocatorTests.cs#L87
Cannot convert null literal to non-nullable reference type.
|
|
ServerPickerX.Tests/Services/DependencyInjection/ServiceLocatorTests.cs#L58
Cannot convert null literal to non-nullable reference type.
|
|
ServerPickerX.Tests/Services/DependencyInjection/ServiceLocatorTests.cs#L17
Possible null reference return.
|
|
ServerPickerX/Services/Settings/JsonSetting.cs#L60
Non-nullable property '_messageBoxService' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
|
|
ServerPickerX/Services/SystemFirewalls/WindowsFirewallService.cs#L125
'type' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicParameterlessConstructor' in call to 'System.Activator.CreateInstance(Type)'. The return value of method 'System.Type.GetTypeFromCLSID(Guid)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
|
|
ServerPickerX/Services/SystemFirewalls/WindowsFirewallService.cs#L128
'type' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicParameterlessConstructor' in call to 'System.Activator.CreateInstance(Type)'. The return value of method 'System.Type.GetTypeFromCLSID(Guid)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
|
|
ServerPickerX/Services/SystemFirewalls/WindowsFirewallService.cs#L128
This call site is reachable on all platforms. 'Type.GetTypeFromCLSID(Guid)' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
|
|
ServerPickerX/Services/SystemFirewalls/WindowsFirewallService.cs#L125
This call site is reachable on all platforms. 'Type.GetTypeFromCLSID(Guid)' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
|
|
ServerPickerX/Services/SystemFirewalls/LinuxFirewallService.cs#L121
The variable 'ex' is declared but never used
|
|
ServerPickerX/Services/SystemFirewalls/LinuxFirewallService.cs#L77
The variable 'ex' is declared but never used
|
|
ServerPickerX/Services/SystemFirewalls/LinuxFirewallService.cs#L45
The variable 'ex' is declared but never used
|
|
ServerPickerX/Services/Settings/JsonSetting.cs#L60
Non-nullable property '_loggerService' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
|
|
ServerPickerX/Services/Settings/JsonSetting.cs#L60
Non-nullable property '_messageBoxService' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
|
The logs for this run have expired and are no longer available.
Loading