fix: replace backslashes with forward slashes in homeURL construction…#23
Open
ImranFarhat01 wants to merge 1 commit into
Open
fix: replace backslashes with forward slashes in homeURL construction…#23ImranFarhat01 wants to merge 1 commit into
ImranFarhat01 wants to merge 1 commit into
Conversation
… (Bug 14)
Save-and-navigate dialogs shown when leaving the editor via Dashboard,
Gallery, or Simulator nav links built homeURL as:
${window.location.protocol}\\${window.location.host}/...
Browsers do not treat backslashes as a protocol separator, so
window.open()/window.location navigation with this malformed URL
fails silently instead of navigating to the intended destination,
leaving the dialog appearing stuck even after a successful save.
Fix: use // instead of \\ in all 4 occurrences (HomeDialog and
SchematicNameDialog, both the 'home' and routeVal branches).
ImranFarhat01
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Save-and-navigate dialogs shown when leaving the editor via Dashboard,
Gallery, or Simulator nav links failed to navigate after a successful
save, leaving the dialog appearing stuck.
Root Cause
homeURL was constructed as:
${window.location.protocol}\${window.location.host}/...
Browsers do not treat backslashes as a protocol separator.
window.open()/window.location navigation with this malformed URL
fails silently instead of navigating to the intended destination.
Fix
Replace \ with // in all 4 occurrences (HomeDialog and
SchematicNameDialog components, both the 'home' and routeVal branches).
Testing
http://localhost/eda/#/dashboard instead of
http:\localhost/eda/#/dashboard
URL produces a broken nested path (http://localhost/localhost/eda/...)
while the fixed URL navigates correctly
Note
This is the same class of bug as the already-fixed Bug (share URL
backslashes), but in a different file/location that was missed.