Fix: save dialog doesn't navigate away when save is a duplicate#24
Open
ImranFarhat01 wants to merge 1 commit into
Open
Fix: save dialog doesn't navigate away when save is a duplicate#24ImranFarhat01 wants to merge 1 commit into
ImranFarhat01 wants to merge 1 commit into
Conversation
…ug 15)
Save-and-navigate dialogs shown when leaving the editor via Dashboard,
Gallery, or Simulator nav links stayed open indefinitely if the saved
content was unchanged since the last save (backend returns
duplicate: true), with no feedback to the user.
Root cause: the success handler only called the navigation callback
(setVersions) when the response was not a duplicate:
if (!res.data.duplicate) { setVersions(res.data.version, false, null) }
This likely intended to skip creating a redundant version record, but
it also skipped navigation entirely, leaving the user stuck with no
indication that the save had already succeeded.
Fix: always call setVersions regardless of duplicate status, so
navigation proceeds whether or not a new version was created.
ImranFarhat01
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Save-and-navigate dialogs shown when leaving the editor via Dashboard,
Gallery, or Simulator nav links stayed open indefinitely if the saved
content was unchanged since the last save, with no feedback to the user.
Root Cause
The backend returns
duplicate: truewhen the posted content matchesan existing save with the same branch. The frontend success handler
only called the navigation callback when the response was not a
duplicate:
if (!res.data.duplicate) { setVersions(res.data.version, false, null) }
This likely intended to skip creating a redundant version record, but
it also skipped navigation entirely, leaving the user stuck with no
indication the save had already succeeded.
Fix
Always call setVersions regardless of duplicate status, so navigation
proceeds whether or not a new version was created.
Testing
save-and-navigate dialog again: backend correctly returned
duplicate: true, and the dialog now navigates to the dashboard
as expected