Fix: LTI URL generation fails silently with missing fields#28
Open
ImranFarhat01 wants to merge 1 commit into
Open
Fix: LTI URL generation fails silently with missing fields#28ImranFarhat01 wants to merge 1 commit into
ImranFarhat01 wants to merge 1 commit into
Conversation
Clicking the LTI URL generation button with empty fields did nothing visible. handleLTIGenerate accessed ltiDetails.modelSchematic.id even when modelSchematic was unset, causing a silent failure (an unhandled error in the console, no feedback on screen). Fix: - Added a check for missing consumer key or secret key - Added a check for a missing/incomplete schematic selection - Both show a clear error message via the existing consumerError display Testing: - Clicking the generate button with all fields empty now shows 'Consumer Key and Secret Key are required.' - Filling in keys but leaving the schematic unselected shows 'Please select a schematic before generating LTI URL.' - Filling in all fields correctly still generates the LTI URL as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking the LTI URL generation button with empty fields did nothing
visible to the user.
Root Cause
The handler accessed the selected schematic's id even when no
schematic was selected, causing a silent failure (an unhandled error
appeared only in the browser console, with no feedback shown on screen).
Fix
already present in the component
Testing
"Consumer Key and Secret Key are required."
"Please select a schematic before generating LTI URL."