fix: return 200 on duplicate save instead of crash code "500"#33
Open
Aditya-Sarna wants to merge 1 commit into
Open
fix: return 200 on duplicate save instead of crash code "500"#33Aditya-Sarna wants to merge 1 commit into
Aditya-Sarna wants to merge 1 commit into
Conversation
Serialize the existing StateSave record when duplicate content is detected so get_lti_id receives a model instance rather than validated request data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.data→get_lti_id()got a dict instead of a model →AttributeErrorFix
StateSaveSerializer(queryset).datavalidated_datafor name/description updates"duplicate": trueTesting
id=..."duplicate": true(was 500)POST /api/savecurl