Skip to content

Removed enumeration and unecessary constants #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shlap merged 1 commit into from
Mar 4, 2026
Merged

Removed enumeration and unecessary constants #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/frc/robot/Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ public class HopperConstants {
// CHANGE TO PROPER RPMS !!!!

public static final double SLOW_SPEED_RPM = 0.0;
public static final double FAST_SPEED_RPM = 0.0;
public static final double REVERSE_SPEED_RPM = 0.0;
public static final double FAST_SPEED_RPM = 100.0;
public static final Voltage VOLTAGE = Volts.of(12.0);
public static final AngularVelocity ANGULAR_VELOCITY = RotationsPerSecond.of(1);
public static final AngularAcceleration ANGULAR_ACCELERATION =
Expand Down
13 changes: 0 additions & 13 deletions src/main/java/frc/robot/subsystems/Hopper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,6 @@
public class Hopper extends SubsystemBase {
private FlywheelMechanism _io;

public enum State {
OFF(RevolutionsPerSecond.of(0.0)),
FORWARD_SLOW(RevolutionsPerSecond.of(HopperConstants.SLOW_SPEED_RPM / 60)),
FORWARD_FAST(RevolutionsPerSecond.of(HopperConstants.FAST_SPEED_RPM / 60)),
REVERSE(RevolutionsPerSecond.of(HopperConstants.REVERSE_SPEED_RPM / 60));

private final AngularVelocity _stateVelocity;

private State(AngularVelocity stateVelocity) {
_stateVelocity = stateVelocity;
}
}

public Hopper(FlywheelMechanism io) {
_io = io;
}
Expand Down