Skip to content

Led code#14

Merged
dlaflotte merged 19 commits intomasterfrom
led-code
Feb 1, 2026
Merged

Led code#14
dlaflotte merged 19 commits intomasterfrom
led-code

Conversation

@abi-appusamy9932
Copy link
Copy Markdown
Contributor

No description provided.

abi-appusamy9932 and others added 4 commits July 9, 2025 15:04
LedIO + CANdle and Sim implementations

LedStrip for high level control
may need to review imports in LedStrip.java
@dlaflotte
Copy link
Copy Markdown
Contributor

@abi-appusamy9932 Ok the issue with the LED library code, I believe, is that you need to call the updates in a subsystem periodic for it to do anything.

You create the LEDStrip in RobotContainer (line 51/52)
public final LedIOCANdle candle = new LedIOCANdle(22, 37); public final LedStrip leds = new LedStrip(candle, "leds");

LEDStrip is a subsystem (so should have its periodic )
@Override public void periodic() { io.updateInputs(inputs); //Logger.processInputs(name, inputs); }

That periodic updates io (which is LedIOCANdle class).
@Override public void updateInputs(LedIOInputs inputs) { inputs.firstHalfColor = firstColor; inputs.secondHalfColor = secondColor; inputs.firstHalfEffect = firstEffect; inputs.secondHalfEffect = secondEffect; }

There isn't anything in any of the periodics to call sendSolidColor() or applyEffects(). You probably need to add an update method to the ledIOCANDle that is called in the LEDStrip.Periodic() that can make sure either the sendSolidColor or the applyEffect functions are called.

@dlaflotte dlaflotte requested a review from Luddo183 February 1, 2026 18:18
@dlaflotte dlaflotte merged commit be3d5f0 into master Feb 1, 2026
3 checks passed
@Luddo183 Luddo183 deleted the led-code branch February 1, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants