Conversation
|
Is this still WIP or should I take a look at it? |
|
As you can see there are some failed tests which I try to fix soon. All the rest could be reviewed meanwhile. |
|
@FRosner |
| # How to connect to Nomad | ||
| nomad { | ||
| # The URL of the Nomad client to be used by Broccoli. | ||
| url = "http://localhost:4646" |
There was a problem hiding this comment.
Please do not change the default value from localhost. If you need custom configuration, please provide a specific application.conf. For more infos on how configuration is read, you can check https://github.com/lightbend/config#standard-behavior
There was a problem hiding this comment.
10x, will look later
| "Resources": { | ||
| "CPU": 50, | ||
| "MemoryMB": 128, | ||
| "DiskMB": 500, |
There was a problem hiding this comment.
@FRosner
Cause Nomad wont run the job with this line as it was.
Here is Nomad output:
default: [NOMAD] 2018/03/16 14:23:56.358846 [ERR] http: Request /v1/jobs, error: 1 error(s) occurred:
default: [NOMAD]
default: [NOMAD] * Task group curl-group validation failed: 1 error(s) occurred:
default: [NOMAD]
default: [NOMAD] * Task curl-task validation failed: 1 error(s) occurred:
default: [NOMAD]
default: [NOMAD] * Task can't ask for disk resources, they have to be specified at the task group level.
There was a problem hiding this comment.
Ah so this is actually something that changed going to a newer Nomad version it seems. I remember that they require you to specify disk info in a different location from now on.
I am not sure I understand. What are you trying to do and where, and what is the error message you are getting? |
|
@FRosner To run tests locally Im doing Here is output: [info] Loading project definition from /Users/ivan/Work/code/src/github.com/Cubic-BB8/cluster-broccoli/project
[info] Set current project to root (in build file:/Users/ivan/Work/code/src/github.com/Cubic-BB8/cluster-broccoli/)
[info] Running webpack resource generator
[info] Compiling 5 Scala sources to /Users/ivan/Work/code/src/github.com/Cubic-BB8/cluster-broccoli/server/target/scala-2.11/it-classes...
[info] UnixSignalManagerIntegrationSpec
[info]
[info] Registering new signal should
[info] + trigger the handler when the signal is raised
[info]
[info]
[info] Total for specification UnixSignalManagerIntegrationSpec
[info] Finished in 1 second, 538 ms
[info] 1 example, 0 failure, 0 error
[info]
Password:
Unable to find image 'frosner/cluster-broccoli-test:latest' locally
docker: Error response from daemon: pull access denied for frosner/cluster-broccoli-test, repository does not exist or may require 'docker login'.
See 'docker run --help'.
Unable to find image 'frosner/cluster-broccoli-test:latest' locally
docker: Error response from daemon: pull access denied for frosner/cluster-broccoli-test, repository does not exist or may require 'docker login'.
See 'docker run --help'. |
|
As you can see in script:
- . prepare-docker-builds
- docker build -t frosner/cluster-broccoli-test docker/test/Please let me know if this is unblocking you :) |
|
Feel free to ping me if you finished the vagrant file. I'm happy to try it out but I'm also fine if @Gerrrr gives it a shot. As you guys prefer. It would be nice to have some documentation on how to use it, maybe adding a section to the readme file or something. It should explain how to "start" it, and then one or two small examples / use cases what you can do with it maybe. |
|
Thanks for the effort! |
|
@FRosner , Actually there are some obstacles which convince me to move Vagrant file into separate repo at all:
Thus, feel free to merge this PR or just follow a new repo. I'm providing a link as soon as repo is created. |
|
New repo also works for me. The first argument is not that ciritical IMO, as the same holds for documentation and we're not paying for the builds. I also don't expect us to change the vagrantfile once per day. I'm not sure I understand the second point. Can you elaborate a bit? Why I think it's good to have it close to the code is that you can clone the repo, spin up the vagrant machine and start developing. |
No description provided.