Fix -fx-highlight-text-fill (selected text color) (issue #303)#428
Open
JFormDesigner wants to merge 3 commits intoFXMisc:masterfrom
Open
Fix -fx-highlight-text-fill (selected text color) (issue #303)#428JFormDesigner wants to merge 3 commits intoFXMisc:masterfrom
JFormDesigner wants to merge 3 commits intoFXMisc:masterfrom
Conversation
Contributor
|
Thanks for filing this @JFormDesigner |
Yevhensh
approved these changes
Mar 12, 2017
Because of JDK bug https://bugs.openjdk.java.net/browse/JDK-8149134 this does not work correctly if a paragraph contains more than one segment and the selection is (also) in the second or later segments. Visually the text color of the selection may be mix black & white.
Jugen
force-pushed
the
fx-highlight-text-fill-fix
branch
2 times, most recently
from
d30371e to
494b398
Compare
Jugen
force-pushed
the
fx-highlight-text-fill-fix
branch
from
494b398 to
43a987f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR should be not yet merged into master because it does not work correctly as long as the JDK bug (see below) is not fixed. Created the PR to avoid that the fix is lost...
This PR attempts to fix text color of selection (white selected text), BUT:
Because of JDK bug https://bugs.openjdk.java.net/browse/JDK-8149134
this does not work correctly if a paragraph contains more than one segment
and the selection is (also) in the second or later segments.
Visually the text color of the selection may be mix black & white.
Sometimes text becomes invisible (white text on white background).
Mixed text selection color:
Sometimes makes text invisible: