Refactor: Replace ThreadStatic with ThreadLocal for Thread Safety#2
Draft
gartia wants to merge 1 commit intoFacepunch:masterfrom
Draft
Refactor: Replace ThreadStatic with ThreadLocal for Thread Safety#2gartia wants to merge 1 commit intoFacepunch:masterfrom
gartia wants to merge 1 commit intoFacepunch:masterfrom
Conversation
…afety The existing use of `ThreadStatic` for `staticBuffer` effectively makes it a global static variable across all threads, with initialization in the static constructor. This approach can lead to issues where multiple threads overwrite each other's data, as each thread does not get its own instance of the buffer. `ThreadLocal<T>`, on the other hand, ensures that each thread gets its own instance of the buffer, initialized independently. This change will enhance the reliability of serialization when `ProtocolParser` is used concurrently across multiple threads. Using this method you are required to use staticBuffer.Value though if any of the non public code is using staticBuffer it will need to be changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing use of
ThreadStaticforstaticBuffereffectively makes it a global static variable across all threads, with initialization in the static constructor. This approach can lead to issues where multiple threads overwrite each other's data, as each thread does not get its own instance of the buffer.ThreadLocal<T>, on the other hand, ensures that each thread gets its own instance of the buffer, initialized independently. This change will enhance the reliability of serialization whenProtocolParseris used concurrently across multiple threads.Using this method you are required to use staticBuffer.Value though if any of the non public code is using staticBuffer it will need to be changed.