[luv-63] fix: disable PostHog telemetry in all CI jobs and test configs#62
Conversation
The build job ran next build which executes instrumentation.node.ts and sent real app_started events to PostHog. Three of four test matrix configs also lacked the disable flag. Add telemetry-disable flags to every CI job, and set the env var in both vitest configs so local test runs are also protected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis pull request systematically disables telemetry across CI workflows and test environments by adding Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
telemetry-disabledtest matrix variant and the e2e job had itenvwith telemetry-disable to both vitest configs so localbun run testis also protectedtelemetry-disabledtest matrix entry (all configs disable telemetry at job level)The biggest leak was the build job —
next buildexecutesinstrumentation.node.tswhich callsinitTelemetry()and sends real events to PostHog on every CI run.Test plan
bun run test:run— all 731 tests pass (47 files)🤖 Generated with Claude Code
Summary by CodeRabbit