Skip to content

[luv-63] fix: disable PostHog telemetry in all CI jobs and test configs#62

Merged
NiveditJain merged 1 commit into
mainfrom
luv-63
Apr 9, 2026
Merged

[luv-63] fix: disable PostHog telemetry in all CI jobs and test configs#62
NiveditJain merged 1 commit into
mainfrom
luv-63

Conversation

@NiveditJain

@NiveditJain NiveditJain commented Apr 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Add telemetry-disable flags to every CI job (quality, test, build, test-e2e) — previously only the telemetry-disabled test matrix variant and the e2e job had it
  • Add Next.js telemetry-disable flag to build and test jobs to suppress native CLI telemetry
  • Add env with telemetry-disable to both vitest configs so local bun run test is also protected
  • Remove the now-redundant telemetry-disabled test matrix entry (all configs disable telemetry at job level)
  • Move matrix env vars to step-level so they merge with the job-level telemetry flag

The biggest leak was the build jobnext build executes instrumentation.node.ts which calls initTelemetry() and sends real events to PostHog on every CI run.

Test plan

  • bun run test:run — all 731 tests pass (47 files)
  • CI passes on all 4 jobs (quality, test x3, build, test-e2e)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflows to disable telemetry across quality, build, and end-to-end test jobs.
    • Updated test configurations to disable telemetry during unit and end-to-end test execution.

The build job ran next build which executes instrumentation.node.ts and
sent real app_started events to PostHog. Three of four test matrix
configs also lacked the disable flag. Add telemetry-disable flags to
every CI job, and set the env var in both vitest configs so local test
runs are also protected.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 9, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f6e46d04-bfbf-45d6-add4-f65193deedab

📥 Commits

Reviewing files that changed from the base of the PR and between ba398fd and 75e770f.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • vitest.config.e2e.mts
  • vitest.config.mts

📝 Walkthrough

Walkthrough

This pull request systematically disables telemetry across CI workflows and test environments by adding FAILPROOFAI_TELEMETRY_DISABLED and NEXT_TELEMETRY_DISABLED environment variables at job and configuration levels, while restructuring the test matrix to remove a dedicated telemetry variant.

Changes

Cohort / File(s) Summary
CI Workflow Telemetry Configuration
.github/workflows/ci.yml
Telemetry disabled environment variables added to quality, build, and test-e2e jobs at job level; test job matrix removes telemetry-disabled variant and now sets telemetry disabled flags job-wide with per-matrix env config passed explicitly to test step.
Vitest Test Configuration
vitest.config.e2e.mts, vitest.config.mts
Both e2e and default Vitest configurations now inject FAILPROOFAI_TELEMETRY_DISABLED: "1" into test environment via test.env setting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Through workflows and configs we hop with delight,
Telemetry silenced—our data takes flight,
No prying eyes watch as we test and we run,
In quiet, encryption-blessed freedom we've won!
DISABLED: "1" echoes through every CI shore, 🔇✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the what, why, and test plan but is missing the required 'Type of Change' and 'Checklist' sections from the template. Add the 'Type of Change' section (mark 'Bug fix') and complete the 'Checklist' section with the status of each item.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: disabling PostHog telemetry across CI jobs and test configurations, which aligns with all modified files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch luv-63

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NiveditJain NiveditJain merged commit 08100a1 into main Apr 9, 2026
8 checks passed
@NiveditJain NiveditJain deleted the luv-63 branch April 21, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant