Convert :trigger to TriggerCommand (#392)#395
Closed
ChrisonSimtian wants to merge 2 commits into
Closed
Conversation
Lift the trigger handler off Program into a standalone IFalloutCommand type and register it directly, replacing its transitional DelegateCommand adapter. Part of the #392 incremental conversion; deletes Program.Trigger.cs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisonSimtian
added
the
target/2026
Name resolution and the "outside a Git repository" guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisonSimtian
force-pushed
the
cli-cmd-trigger
branch
from
52bfda3 to
1161bf2
Compare
Collaborator
Author
|
Superseded as part of moving the cli-cmd stack off the main repo. Now tracked on the fork as ChrisonSimtian#26; it'll be re-raised here as a cross-fork PR from the fork branch once the PR below it merges (foundation is #448). Same history and diff; branch left in place for now. |
Collaborator
Author
|
Correction: the fork twin for this PR is ChrisonSimtian#17 (not #26). The rest of the plan stands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #392 (one command per PR). Stacked on #394 — auto-retargets to
mainonce it lands.Lifts
:triggerinto a standaloneTriggerCommand : IFalloutCommand, registered directly; removes its transitionalDelegateCommandadapter and deletesProgram.Trigger.cs. Self-contained, no shared helpers. Name/behaviour unchanged.🤖 Generated with Claude Code