Fix UpdateSolutionFileContentSpecs not testing anything#464
Merged
Conversation
ITaluone
force-pushed
the
fix/update-solution-tests
branch
from
d6a8506 to
3a8bf14
Compare
ITaluone
commented
Jul 1, 2026
ITaluone
force-pushed
the
fix/update-solution-tests
branch
2 times, most recently
from
b4774c5 to
7d102ed
Compare
ChrisonSimtian
approved these changes
Jul 4, 2026
ChrisonSimtian
added
the
Can Merge
ITaluone
force-pushed
the
fix/update-solution-tests
branch
from
7d102ed to
21cfaaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized while studying the
UpdateSolutionFileContentSpecswhile preparing #461 that the tests above actually not testing anything, because passing in a string and verify this exact string isn't what a test is for ;)