Add obsolete-APIs diagnostic-ID registry (FALLOUTOBS0xx)#472
Merged
ITaluone merged 1 commit intoJul 10, 2026
Conversation
Introduce docs/obsolete_apis.md as the canonical registry of FALLOUTOBS0xx diagnostic IDs for [Obsolete] deprecations, so TreatWarningsAsErrors consumers can NoWarn a single deprecation instead of blanket-disabling CS0618. Mirrors the [Experimental] FALLOUT0xx registry but uses a separate, never-colliding ID sequence. Document the [Obsolete] + DiagnosticId convention in docs/agents/conventions.md and cross-link both from AGENTS.md rule Fallout-build#2. Scaffold only: the registry starts empty; the first ID (FALLOUTOBS001, legacy workflow_dispatch input arrays) is allocated by the typed-dispatch-inputs work that builds on it.
ITaluone
approved these changes
Jul 8, 2026
ChrisonSimtian
approved these changes
Jul 10, 2026
ChrisonSimtian
added
the
Can Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
docs/obsolete_apis.md— the canonical registry ofFALLOUTOBS0xxdiagnostic IDs for[Obsolete]deprecations.Why
A warning-level
[Obsolete]can break consumers building withTreatWarningsAsErrors. A per-deprecationDiagnosticIdlets themNoWarna single deprecation instead of blanket-disablingCS0618.What
docs/experimental-apis.mdbut with a separateFALLOUTOBS0xxsequence — aNoWarncan never collide between an experimental and an obsolete API.[Obsolete]+DiagnosticIdconvention section indocs/agents/conventions.md; cross-linked fromAGENTS.mdrule Enterprise hardening: repo nuget.config breaks corporate packageSourceMapping setups #2.Builds on
FALLOUTOBS001(legacyworkflow_dispatchinput arrays) is allocated + wired onto the[Obsolete]attributes in the typed-dispatch-inputs PR (#386).Docs-only — CI ignores
**/*.md.