Skip to content

Bug fixed in intersect#112

Open
tarod13 wants to merge 1 commit intoFarama-Foundation:masterfrom
tarod13:patch-1
Open

Bug fixed in intersect#112
tarod13 wants to merge 1 commit intoFarama-Foundation:masterfrom
tarod13:patch-1

Conversation

@tarod13
Copy link
Copy Markdown

@tarod13 tarod13 commented Apr 11, 2024

Description

If the forward step is large enough (I guess larger than the agent's radius), the new position of the agent may be outside of the world. Thus, one needs to check that it remains inside. With the current version of intersect_circle_segs this doesn't happen due to clipping and norm operations.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

If the forward step is large enough, the new position of the agent may be outside of the world. Thus, one needs to check that it remains inside. With the current version of intersect_circle_segs this doesn't happen due to clipping and norm operations.
@pseudo-rnd-thoughts
Copy link
Copy Markdown
Member

Hi thanks for the PR,
How did you discover the bug?

Could you provide an example video of the problem occurring?
Then with the same example, of the problem not occurring with the suggested fix.

Second, could provide some training plots, with and without the fix? Just to confirm that nothing else weird is happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants