Skip to content

Comments

fix(agents): honor MODEL_PROVIDER for subagent routing#52

Merged
veerareddyvishal144 merged 1 commit intoFast-Editor:mainfrom
Plaidmustache:codex/pr-bugfix-subagent-provider
Feb 18, 2026
Merged

fix(agents): honor MODEL_PROVIDER for subagent routing#52
veerareddyvishal144 merged 1 commit intoFast-Editor:mainfrom
Plaidmustache:codex/pr-bugfix-subagent-provider

Conversation

@Plaidmustache
Copy link
Contributor

@Plaidmustache Plaidmustache commented Feb 16, 2026

Description

Fixes subagent routing so Task/subagent execution honors configured MODEL_PROVIDER instead of defaulting to Azure.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Performance improvement
  • Refactoring

Changes Made

  • Updated subagent provider resolution in src/agents/executor.js.
  • Replaced hard fallback to azure-openai with configured provider resolution:
    • config.modelProvider?.type || config.modelProvider?.provider || null
  • Applies to Claude-family and GPT-family subagent models.

Testing

  • Existing tests pass
  • Added new tests
  • Manual testing performed

Manual checks:

  • npm run test:quick passed.
  • Verified bug path/repro condition and fix behavior for non-Azure provider setups.

Checklist

  • Code follows style guidelines
  • Documentation updated
  • Tests added/updated
  • No new warnings

Notes

  • Scope intentionally minimal (single-file bug fix).
  • No secrets or local environment values are included.

Bug fix: remove hardcoded azure-openai fallback in SubagentExecutor._callModel. Subagents now use config.modelProvider.type (with legacy provider fallback) for Claude/GPT family models. This prevents Task/subagent failures on non-Azure setups (e.g., moonshot/openai/openrouter).
@Plaidmustache
Copy link
Contributor Author

Plaidmustache commented Feb 16, 2026

Maintainer note: this is intentionally scoped to one bug-fix file (src/agents/executor.js) to keep review and rollback simple. Repro was non-Azure Task/subagent execution failing due to unintended Azure fallback. Validation run: npm run test:quick (pass).

@veerareddyvishal144
Copy link

veerareddyvishal144 commented Feb 18, 2026

Thanks @Plaidmustache for the contribution. This really means a lot

@veerareddyvishal144 veerareddyvishal144 merged commit 221d7c5 into Fast-Editor:main Feb 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants