Skip to content

test(library-selection): #205 add pass-2 reconciliation regression + CI badges#222

Merged
zackees merged 1 commit intomainfrom
chore/205-ldf-test-and-badges
May 10, 2026
Merged

test(library-selection): #205 add pass-2 reconciliation regression + CI badges#222
zackees merged 1 commit intomainfrom
chore/205-ldf-test-and-badges

Conversation

@zackees
Copy link
Copy Markdown
Member

@zackees zackees commented May 10, 2026

Summary

Two final polish items before closing #205.

Test — r04_pass2_reconciliation_catches_cpp_only_dependency

The canonical "why 2-pass beats single-pass BFS" scenario, which the existing 16-test suite was missing as an explicit guard:

  • Project includes <SPI.h>. SPI.h is silent (no transitive includes).
  • SPI.cpp is the only place that includes <Wire.h>.

A single-pass BFS over headers selects {SPI} and silently misses Wire — link-time undefined symbols. The LDF's pass 2 re-seeds with each selected lib's full source set, so Wire is reached and selected. Test asserts {SPI, Wire} and is the regression guard against accidentally collapsing the resolver back to a single pass.

Brings the resolver test count to 17 (10 LDF + 7 cache).

README badges

Adds badges for the two #205 workflows to the CI status block:

  • acceptance-205.yml — AC#1 (teensyLC) and AC#4 (stm32 SPI) gates
  • bench-205.yml — P-02 (cold) / P-03 (scanner) / P-01-mini (warm) perf gates

Both have been live since #211 / #210 but were not discoverable from the README.

Test plan

  • uv run soldr cargo test -p fbuild-library-select --lib — 17/17 pass
  • Resolver lint clean

Refs: #205. After this lands, all six AC's are met:

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 10, 2026

Warning

Rate limit exceeded

@zackees has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minute and 28 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 54d9bccb-89d1-4d2d-b1a5-feeca9296984

📥 Commits

Reviewing files that changed from the base of the PR and between 787cc82 and 3acfff5.

📒 Files selected for processing (3)
  • README.md
  • crates/fbuild-build/tests/teensylc_acceptance.rs
  • crates/fbuild-library-select/src/lib.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/205-ldf-test-and-badges

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees force-pushed the chore/205-ldf-test-and-badges branch from a8ad5ff to a49d744 Compare May 10, 2026 16:33
…nsylc env, add CI badges

Three final polish items before closing #205.

## test — `r04_pass2_reconciliation_catches_cpp_only_dependency`

The canonical "why 2-pass beats single-pass BFS" scenario, which the
existing 16-test suite was missing as an explicit guard:

- Project includes `<SPI.h>`. `SPI.h` is silent (no transitive includes).
- `SPI.cpp` is the *only* place that includes `<Wire.h>`.

A single-pass BFS over headers selects {SPI} and silently misses Wire —
link-time undefined symbols. The LDF's pass 2 re-seeds with each
selected lib's full source set, so Wire is reached and selected. Test
asserts {SPI, Wire} and is the regression guard against accidentally
collapsing the resolver back to a single pass. Brings the resolver test
count to 17 (10 LDF + 7 cache).

## fix — teensylc acceptance gate env name

`tests/teensylc_acceptance.rs` passed `env_name: "teensyLC"`
(camelCase) and looked up `compile_commands.json` under
`<build>/teensyLC/`. The actual env in
`tests/platform/teensylc/platformio.ini` is `[env:teensylc]`
(lowercase) — same case-sensitivity bug fixed in #220 / #221 for
`measure_baseline_205.py`. The acceptance gate has been failing on
every run (including main) for this reason.

## badges

Adds badges for the two #205 workflows to README.md's CI status block:

- `acceptance-205.yml` — AC#1 (teensyLC) and AC#4 (stm32 SPI) gates
- `bench-205.yml` — P-02 (cold) / P-03 (scanner) / P-01-mini (warm)
  perf gates

Both have been live since #211 / #210 but were not discoverable from
the README.

Refs: #205.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@zackees zackees force-pushed the chore/205-ldf-test-and-badges branch from a49d744 to 3acfff5 Compare May 10, 2026 16:40
@zackees zackees merged commit 58d1b1d into main May 10, 2026
77 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant