Skip to content

Use restriction the getimagesize() function with https #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjchamado wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use restriction the getimagesize() function with https #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7c996c
Fixed bug getimagesize() with url, not image path
cjchamado Jan 12, 2016
bba2754
Fefactored resolveFilepath function
cjchamado Jan 12, 2016
906298f
Refactored function resolveFilepath()
cjchamado Jan 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 39 additions & 14 deletions Service/ImageHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,24 +55,49 @@ public function getUrl($filename, $subdir)

return $request->getScheme() . '://' . $request->getHttpHost() . $request->getBasePath() . $this->container->getParameter('fbeen_croppic.upload.' . $subdir) . '/' . $filename;
}


/**
* @param $imgUrl
* @return string
*/
public function resolveFilepath($imgUrl)
{
$filepath = $this->container->getParameter('fbeen_croppic.upload.filepath');
$original = $this->container->getParameter('fbeen_croppic.upload.original');

$firstToken = strpos($imgUrl, $original);

if(false == $firstToken)
return $imgUrl;

$baseFilepath = substr($imgUrl, $firstToken+strlen($original));

return $filepath . $original .$baseFilepath;
}

/**
* @param Crop $crop
* @return bool
*/
public function crop(Crop $crop)
{
$what = getimagesize($crop->getImgUrl());
$filepath = $this->resolveFilepath($crop->getImgUrl());

$what = getimagesize($filepath);

switch(strtolower($what['mime']))
{
case 'image/png':
$img_r = imagecreatefrompng($crop->getImgUrl());
$source_image = imagecreatefrompng($crop->getImgUrl());
$img_r = imagecreatefrompng($filepath);
$source_image = imagecreatefrompng($filepath);
break;
case 'image/jpeg':
$img_r = imagecreatefromjpeg($crop->getImgUrl());
$source_image = imagecreatefromjpeg($crop->getImgUrl());
$img_r = imagecreatefromjpeg($filepath);
$source_image = imagecreatefromjpeg($filepath);
break;
case 'image/gif':
$img_r = imagecreatefromgif($crop->getImgUrl());
$source_image = imagecreatefromgif($crop->getImgUrl());
$img_r = imagecreatefromgif($filepath);
$source_image = imagecreatefromgif($filepath);
break;
default:
return FALSE;
Expand All @@ -81,28 +106,28 @@ public function crop(Crop $crop)
// resize the original image to size of editor
$resizedImage = imagecreatetruecolor($crop->getImgW(), $crop->getImgH());
imagecopyresampled($resizedImage, $source_image, 0, 0, 0, 0, $crop->getImgW(), $crop->getImgH(), $crop->getImgInitW(), $crop->getImgInitH());

// rotate the rezized image
$rotated_image = imagerotate($resizedImage, -$crop->getRotation(), 0);

// find new width & height of rotated image
$rotated_width = imagesx($rotated_image);
$rotated_height = imagesy($rotated_image);

// diff between rotated & original sizes
$dx = $rotated_width - $crop->getImgW();
$dy = $rotated_height - $crop->getImgH();

// crop rotated image to fit into original rezized rectangle
$cropped_rotated_image = imagecreatetruecolor($crop->getImgW(), $crop->getImgH());
imagecolortransparent($cropped_rotated_image, imagecolorallocate($cropped_rotated_image, 0, 0, 0));
imagecopyresampled($cropped_rotated_image, $rotated_image, 0, 0, $dx / 2, $dy / 2, $crop->getImgW(), $crop->getImgH(), $crop->getImgW(), $crop->getImgH());

// crop image into selected area
$final_image = imagecreatetruecolor($crop->getCropW(), $crop->getCropH());
imagecolortransparent($final_image, imagecolorallocate($final_image, 0, 0, 0));
imagecopyresampled($final_image, $cropped_rotated_image, 0, 0, $crop->getImgX1(), $crop->getImgY1(), $crop->getCropW(), $crop->getCropH(), $crop->getCropW(), $crop->getCropH());

// finally output png image
imagejpeg($final_image, $this->getPath(basename($crop->getImgUrl()), 'cropped'), 100);
}
Expand Down