fix(run): push tags to dummy remote so semantic-release stops failing#141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why semantic-release is missing from the perf comparison table
When the bench runner reaches the semantic-release step it does:
setup_dummy_remotedoesgit init --bare+git push origin HEADbut no tags. semantic-release's planning phase fetches tags very early to resolve the previous release, sees an empty tag set, and dies with exit 128 —run.shthen reportsSKIP: command failedfor every (fixture, semantic-release) pair.Same root cause is going to bite any future Node-based tool that derives version state from tags (which is most of them).
Fix
One extra
git push --tagsafter thegit push HEAD.-qkeeps the output silent and|| truematches the existing pattern — even on fixtures with no tags it's a no-op, not an error.After this lands, semantic-release should start appearing as a real comparison row in the npm section of the perf table.