ci: add release concurrency guard and drop persisted creds on the bot release#148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #129.
Two race/auth hardening fixes on the inline
releasejob inci.yml(this repo has no separate release.yml — the release runs inside CI):concurrency: { group: release-${{ github.ref }}, cancel-in-progress: false }so two main merges can't race the FerrFlow release run and tripE2006: tag already exists.FerrLabs/FerrFlow@v5withbot: true, which pushes via an App installation token from its OIDC exchange, not the checkout-persistedGITHUB_TOKEN. Addedpersist-credentials: falseso the persistedGITHUB_TOKENcan't win over the bot token on push (github-actions[bot] can't bypass the branch ruleset).Note: the parent issue/#56 prescribed
checkout@v6 → v5to dodge v6 dropping GITHUB_TOKEN onfetch-depth: 0. That workaround doesn't apply here because this release doesn't use GITHUB_TOKEN for the push (it uses the bot token) —persist-credentials: falseon v6 is the correct, current pattern (matches the FerrLabs/.github reusable release). Kept@v6.