Skip to content

fix(bench): measure ferrflow_parallel only from the binary method #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryanFRD merged 1 commit into from
Jul 2, 2026
+7 −2
Merged

fix(bench): measure ferrflow_parallel only from the binary method #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,10 +319,15 @@ for tool in $TOOLS; do

# Competitors are single-threaded; pin ferrflow to one thread so the
# comparison is reproducible and apples-to-apples. par_cmd keeps the
# all-cores variant for the separate parallel stat.
# all-cores variant for the separate parallel stat — binary method
# only, since the parallel result file is not method-scoped and the
# npm (npx) and docker methods would overwrite it with node/container
# startup overhead instead of the binary's all-cores time.
par_cmd=""
if [[ "$tool" == "ferrflow" ]]; then
par_cmd="$full_cmd"
if [[ "$method" == "binary" ]]; then
par_cmd="$full_cmd"
fi
full_cmd="$tool_cmd --jobs 1 $cmd"
fi

Expand Down
Loading