fix(build): sync Cargo.lock to the 5.20.0 manifest version#616
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: c05fb2b | Previous: 0b5fe57 | Ratio |
|---|---|---|---|
git_find_tag/100 |
1111648 ns/iter (± 10751) |
||
git_find_tag/1000 |
10004749 ns/iter (± 59250) |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The v5.20.0 release commit bumped
Cargo.tomltoversion = "5.20.0"but left the rootCargo.lockpinningferrflow 5.19.0. The manifest and lockfile are out of sync, socargo build --lockedfails onmain.This runs
cargo update -p ferrflow --offlineand commits only the resulting one-line change so the lock'sferrflowentry becomes5.20.0.Diff scope
Limited to the single
ferrflowversion line inCargo.lock— no unrelated dependency bumps.Context
This is the exact class of post-bump lockfile staleness that #498 (auto-update lockfiles after version bump) is meant to prevent. Until that lands, the lock has to be synced by hand after each release — which is what this PR does for 5.20.0.