ci: allow the benchmark job to run on workflow_dispatch#625
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: c86889f | Previous: 0b5fe57 | Ratio |
|---|---|---|---|
commit_parsing/100 |
17665 ns/iter (± 165) |
17091 ns/iter (± 38) |
1.03 |
commit_parsing/1000 |
179096 ns/iter (± 630) |
174058 ns/iter (± 2250) |
1.03 |
commit_parsing/10000 |
1807982 ns/iter (± 5458) |
1809492 ns/iter (± 18830) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The competitive benchmark job only runs on push-to-main, so it can't be triggered on demand — re-running the job via
gh run rerundoesn't regenerate the baseline. Allow it onworkflow_dispatchtoo (thetestdependency already runs on that event).Lets us refresh the bench manually (e.g. to validate a Benchmarks-action change like the published-binary size measurement) without an unrelated push.
Closes #624