fix: correct FerrVault SAT prefix to fvsat_ and drop dead DefaultAudience const#156
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
Follow-up cleanup from removing ferrflow naming.
DefaultAudienceconst (= "https://ferrflow.com") — referenced nowhere; its comment falsely claimed it matched a FerrVaultEXPECTED_AUDIENCEthat does not exist (the FerrVault API uses configurableFERRVAULT_JWT_AUDIENCE, default off).Audiencefield doc — it must match the target API's expected audience per mode, not a hardcodedferrflow.com.sat_→fvsat_in theferrvault-mode doc, the connection sample, and the client comment (the real prefix, peraction/README.md+ the threat model).Non-breaking (dead-code removal + doc/sample corrections). The remaining
ferrflowreferences describe thecloud(legacy FerrLabs-Cloud) backend that was kept on purpose —ffclust_/fft_tokens are genuinely FerrFlow.go build/vet/testpass; removing the const broke nothing (confirming it was unused).Closes #155
@