fix(cli): use keyring-core + native platform stores (drop keyring meta-crate)#165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #163. Supersedes #164 (the
cli-feature quick fix, which dragged in clap, rpassword and a SQLite engine).CI (Rust CLI)has been red onmainsince the keyring 4.1.0/4.1.1 bumps (#159/#160): keyring 4.1 moveduse_native_storebehind aclifeature, sokeyring::use_native_storeno longer resolves with default features.The keyring maintainers explicitly recommend that real apps link
keyring-core+ only the platform store crates they need, rather than thekeyringmeta-crate. This does that:keyringdependency. Keepkeyring-core(already used forEntry).zbus-secret-service-keyring-store(Linux,crypto-rust),apple-native-keyring-store(macOS,keychain),windows-native-keyring-store(Windows).storage.rssets the default store viakeyring_core::set_default_store(<platform>::Store::new_with_configuration(..))under#[cfg(target_os)]. Behavior is identical to the olduse_native_store(true)(Linux → Secret Service via zbus).No SQLite/clap/rpassword pulled in: the lockfile shrinks (−13 net) instead of the +1443 the
clifeature added.Verified locally on Windows:
cargo check,cargo clippy --all-targets -- -D warnings(pedantic on),cargo fmt --checkall green. CI covers Linux.