Fix alignment for NetShareEnum request handling#23
Open
buttercookie42 wants to merge 1 commit intoFileSysOrg:masterfrom
Open
Fix alignment for NetShareEnum request handling#23buttercookie42 wants to merge 1 commit intoFileSysOrg:masterfrom
buttercookie42 wants to merge 1 commit intoFileSysOrg:masterfrom
Conversation
The missing alignment meant that the info level was being misread if the host name of the server had an even number of characters, because in that case the end of the string ended up not being 4-byte-aligned. This meant that the info level was being misread as e.g. 65536 instead of 1, which had the ultimate result that instead of success and a list of the available shares, an error message would be sent back and the server couldn't be accessed.
buttercookie42
force-pushed
the
alignment
branch
2 times, most recently
from
8acb943 to
37d7f1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing alignment meant that the info level was being misread if the host name of the server had an even number of characters, because in that case the end of the string ended up not being 4-byte-aligned.