fido2prf: try to assert without a PIN first#48
Open
yorickvP wants to merge 1 commit intoFiloSottile:mainfrom
Open
fido2prf: try to assert without a PIN first#48yorickvP wants to merge 1 commit intoFiloSottile:mainfrom
yorickvP wants to merge 1 commit intoFiloSottile:mainfrom
Conversation
For my device that has a screen for the PIN, supplying any PIN will cause the assertion to fail. Try doing it without the PIN first. (it's impossible to enter an empty PIN via getPIN in the current code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my device that has a screen for the PIN, supplying any PIN will cause the assertion to fail, making the fido2prf plugin unusable. This PR changes the code to first try without a PIN and handling ErrPinRequired.