Update 124.yaml

[vlevy573]

Description

Change Metadata

Resolves: # (issue)

This change includes the following change types

• Bug report fix(es)
• Enhancement to assessment(s)
• Enhancement to specification(s)
• Enhancement to tool(s)
• Enhancement to documentation(s)
• Other

Quality Assurance

• I have checked to ensure there are no other open PRs for the same change.
• I have read and am following to the best of my abilities what is in CONTRIBUTING.md
• I have read and am following to the best of my abilities the relevant design, development, and style guidelines

[travissalascox]

Hey there @Tanjiha , like a lot of what you did here. I especially like the detail here. Have just a question and few suggestions on this.

First for the question. Was trying to count up the scoring in a few different ways, but was having trouble coming up with the max score mentioned here. It seems like the max unweighted scores here are 3, 2, 5, and 3. Which when I apply the weights comes out to 3*3 + 3*2 + 2*5 + 2*3 = 31 . So was just wondering where the 40 max score came from?

Now, in terms of suggestions, mostly just think the scoring needs to be slightly re-worded. The scores we use are integers to work with the excel file. We don't really support ranges like this. So for the score, would suggest picking the rounded value of the last value in the range, and then in the condition tell people the maximum amount of raw points they need to achieve that score. That way you can drop the normalization parts (since you would essentially be doing the normalization in the conditions for people), and can change the output range to the 0 - Max raw.

I also like the crawl, walk, run, fly that you did here, but we don't really tend to use those as conditions because of the ambiguity of them. So would suggest to talk about that mapping in the Notes section below References. And would include any references links you have to crawl, walk, run, fly in References.

Again, great work here. Like what you did this action

[Tanjiha]

Made changes to the notes to be <120 charactors

[travissalascox]

hey @Tanjiha , great work on the changes!! this looks great now. I see your comment about the 120 character, we have some tricks for the Supplement Guidance/Notes section. Sorry for not getting this to you yesterday, I hope it doesn't throw off things too much for you.

But you can use the | or |- characters like in here https://github.com/FinOpsPP/Framework-Assessment/blob/main/specifications/actions/000.yaml#L45 to allow multi-line comments. Each line will still have the 120 character limit, but with those in your guidance/notes, once you get to the 120th character you can just press enter and start on the next line.

Hopefully that will allow you to write as much as you need or want in that section without having to cut down too much to make that 120 character limit.

[travissalascox]

Also see there is a merge conflict, luckily it is an easy one with the modified date. Would just click the Resolve conflicts button and accept your current date change over the other one. Think after that and the validation fixes, this will also be ready to go in!