test(rewards): cover contract edge cases#63
Merged
joelpeace48-cell merged 3 commits intoFinesseStudioLab:mainfrom Mar 25, 2026
Merged
test(rewards): cover contract edge cases#63joelpeace48-cell merged 3 commits intoFinesseStudioLab:mainfrom
joelpeace48-cell merged 3 commits intoFinesseStudioLab:mainfrom
Conversation
|
@sshdopey is attempting to deploy a commit to the joelpeace48-cell's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@sshdopey Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@FinesseStudioLab this resolves #10 and is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add the missing edge-case tests across the rewards and campaign contracts.
Why
Fixes #10
The contracts need direct coverage for insufficient claims, overflow handling, duplicate campaign registration, and safe access before rewards initialization.
How
This expands the rewards tests with claim, overflow, and uninitialized read coverage, and adds a focused campaign test for duplicate registration returning false.
Testing
cargo test --workspace