Fix Apple Silicon source install requirements#15
Draft
yyovil wants to merge 1 commit intoFireRedTeam:mainfrom
Draft
Fix Apple Silicon source install requirements#15yyovil wants to merge 1 commit intoFireRedTeam:mainfrom
yyovil wants to merge 1 commit intoFireRedTeam:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the source-install dependency set to better support Apple Silicon and other CPU-only environments by removing CUDA-specific PyTorch constraints and loosening a problematic wheel pin, with a README note for CUDA users.
Changes:
- Switch
requirements.txtfrom a CUDA-suffixed Torch pin to a platform-neutral PyTorch spec. - Relax the
kaldi_native_fbankversion constraint to allow resolving Apple Silicon-compatible wheels. - Document in the README that CUDA users should install their preferred PyTorch build separately for source installs.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements.txt | Replaces CUDA-specific Torch pin with a generic Torch constraint; loosens kaldi_native_fbank pin. |
| README.md | Adds guidance clarifying PyTorch installation expectations for CUDA users on the source-install path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this helps
The README currently promises that source users can set up the project with
pip install -r requirements.txt.Before this PR, that promise was broken on Apple Silicon and other non-CUDA environments because the requirements file forced a CUDA-specific PyTorch build and pinned
kaldi_native_fbankto a version without a native macOS arm64 wheel.After this PR, the source install path becomes platform-neutral again: pip can choose a compatible PyTorch wheel for the current environment, and it can resolve a newer
kaldi_native_fbankbuild with Apple Silicon support.Before
pip install -r requirements.txtfailed on native Apple Silicon environmentstorch==2.1.0+cu118forced a CUDA-only wheel in a general-purpose requirements filekaldi_native_fbank==1.15blocked pip from selecting newer arm64 macOS wheelsAfter
pip install -r requirements.txtresolves on Apple Silicon native PythonChanges
requirements.txtwith a platform-neutral PyTorch dependencykaldi_native_fbankpin so Apple Silicon can resolve a compatible wheelTesting
python -m pip install --dry-run --ignore-installed --no-deps -r requirements.txtpython -m pip install --dry-run --ignore-installed --no-deps --only-binary=:all: --platform macosx_11_0_arm64 --python-version 3.11 --implementation cp --abi cp311 -r requirements.txtCloses #8.