Complete Pj-specific TE move to separatate spec#85
Conversation
danh-arm
left a comment
danh-arm
left a comment
There was a problem hiding this comment.
We'll need to take care that the TEs in the other repo are sync'd with this one when we merge this.
|
|
||
| .. [SPMCATTR] `The SPMC manifest v2.12: <https://hafnium.readthedocs.io/en/v2.12.0/secure-partition-manager/secure-partition-manager.html#spmc-manifest>`__ | ||
|
|
||
| .. [FWH_Project_Entries] `Firmware Handoff Project Entries <https://github.com/FirmwareHandoff/ProjectEntries>`__ No newline at end of file |
There was a problem hiding this comment.
I think the ProjectEntries repo name is too generic. Suggest ProjectTransferEntries or ProjectTEs.
There was a problem hiding this comment.
Renamed the repo to ProjectTEs (https://github.com/FirmwareHandoff/ProjectTEs) and updated this reference.
|
|
||
| * - :ref:`0x109 <tab_gpt_info>` | ||
| * - 0x109 | ||
| - GPT Error Info |
There was a problem hiding this comment.
I think it would be more maintainable if you just reserve out the TagID ranges in this spec rather than summarising the TagIDs and their names. It might be good to reserve out a larger block now to avoid updating this spec when adding new TF TEs.
There was a problem hiding this comment.
Changed the table to list the ranges in ProjectTEs.
| - data_size | ||
| - hdr_size | ||
| - The `gpt_error_info` field contains GPT error information. | ||
| Whenever a new project specific transfer entry is declared in the ancillary specification [FWH_Project_Entries]_, its tag id must be documented in :numref:`tab_entries_summary`. |
There was a problem hiding this comment.
If you take my other comment than you can change this to say that this spec must be updated when that spec defines a new TE outside the reserved range(s).
There was a problem hiding this comment.
updated to:
"Whenever a new tag id range is declared in the ancillary specification [FWH_Project_Entries]_, or an existing tag id range is extended, :numref:tab_entries_summary must be updated accordingly."
jmarinho
force-pushed
the
move_TEs_to_project_specific_spec
branch
from
7aec2fc to
7fa1312
Compare
jmarinho
force-pushed
the
move_TEs_to_project_specific_spec
branch
from
7fa1312 to
3a5d521
Compare
| .. list-table:: GPT info type layout | ||
| :widths: 2 2 2 8 | ||
| .. _tab_entries_summary: | ||
| .. list-table:: List of tag ids ranges in the Project Specific Entries ancillary specification |
There was a problem hiding this comment.
nit: tag ID ranges
| - Size (bytes) | ||
| - Offset (bytes) | ||
| - Description | ||
| The following tag id ranges are used by that specification. |
There was a problem hiding this comment.
This needs to be deleted or changed to project specific entries.
There was a problem hiding this comment.
fixed line 598, rewrote it as "Project Specific Entries (:numref:project_specific_entries)."
jmarinho
force-pushed
the
move_TEs_to_project_specific_spec
branch
from
3a5d521 to
a4c1c37
Compare
There was a problem hiding this comment.
I think we need to clean up these dangling references:
checking consistency... /workspaces/tf-a-projects/fw-handoff/core-spec/source/references.rst:24: WARNING: Citation [OPTEECore] is not referenced.
/workspaces/tf-a-projects/fw-handoff/core-spec/source/references.rst:26: WARNING: Citation [TFAFFAMB] is not referenced.
/workspaces/tf-a-projects/fw-handoff/core-spec/source/references.rst:30: WARNING: Citation [TF_BL31] is not referenced.
/workspaces/tf-a-projects/fw-handoff/core-spec/source/references.rst:32: WARNING: Citation [SPMCATTR] is not referenced.
| - data_size | ||
| - hdr_size | ||
| - The `gpt_error_info` field contains GPT error information. | ||
| Whenever a new tag id range is declared in the ancillary specification [FWH_Project_Entries]_, or an existing tag id range is extended, :numref:`tab_entries_summary` must be updated accordingly. |
There was a problem hiding this comment.
nit: same on this line /id/ID
jmarinho
force-pushed
the
move_TEs_to_project_specific_spec
branch
from
a4c1c37 to
63f2b0d
Compare
The TEs specific to a project (or a small collection or projects) were moved to a separate spec (https://github.com/FirmwareHandoff/ProjectTEs). The main FW Handoff spec only carries the tag id range list for those TEs. Any new tag id range declared in the separate spec, must be documented in the main FW Handoff spec. Change-Id: If718d948dc4cd4d87d537474538f0ea64865b0e9 Signed-off-by: Jose Marinho <jose.marinho@arm.com>
jmarinho
force-pushed
the
move_TEs_to_project_specific_spec
branch
from
63f2b0d to
ef5f42e
Compare
| - 0x4 | ||
| - The size of the GPT error information in bytes, it is always 1 byte. | ||
| * - 0x100 -- 0x109 | ||
| - TF-A and Arm ecosystem Secure World Software Transfer Entries |
There was a problem hiding this comment.
Two thoughts on this. First, should we broaden this into a more general “Arm Firmware” range? Over time, we’ll likely want to include entries beyond Secure World software (for example, RMM). Second, I’m not sure whether we should allocate a few more slots within this range. The spec does recommend grouping tag IDs into logical clusters at 16- or 256-aligned boundaries.
There was a problem hiding this comment.
on the first point, my 2 cents is to rename this when other projects request new ranges.
On the second point, I agree with extending the reservation to 256 for the Secure World TE range, will let @danh-arm and @manish-pandey-arm comment.
3 participants
The TEs specific to a project (or a small collection or projects) were moved to a separate spec
(https://github.com/FirmwareHandoff/ProjectEntries).
The main FW Handoff spec only carries the tag id list for those TEs. Any new TE declared in the separate spec, must have its tag id listed in the main FW Handoff spec.
Change-Id: If718d948dc4cd4d87d537474538f0ea64865b0e9