FIBAS-1460-add-redirect-uri-for-python-package#5
Merged
Muhamad-jamal merged 2 commits intomainfrom Mar 9, 2025
Merged
Conversation
Muhamad-jamal
requested review from
Bawan-Zana,
Hazhee,
codezardasht,
hananDlshad,
omer-hanaraey,
ravensborn and
rawahamid
as code owners
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Hazhee
requested changes
Mar 6, 2025
Hazhee
left a comment
Hazhee
left a comment
There was a problem hiding this comment.
bram in this package config has been used like the callback URI so suggest to use the same for redirect URI, in this case we have to update the config and .env.example to include the redirect URI. and please update the readme to include redirect URI in the env variables section and the example code in the examples folder, as well as update the package version in the setup.py to 0.2.0
Hazhee
approved these changes
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.