Fix IsValid to use UTC for timestamp comparison#6
Open
mtnadb wants to merge 2 commits intoFiscalAPI:mainfrom
Open
Fix IsValid to use UTC for timestamp comparison#6mtnadb wants to merge 2 commits intoFiscalAPI:mainfrom
mtnadb wants to merge 2 commits intoFiscalAPI:mainfrom
Conversation
Updated IsValid property to convert timestamps to UTC for accurate comparison.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Token.IsValid compara DateTime.UtcNow con ValidFrom/ValidTo tal cual. Si las fechas deserializadas tienen un DateTimeKind distinto (por ejemplo Unspecified o Local) la comparación puede fallar en tiempo de ejecución aunque en el depurador parezca correcta. La solución es normalizar las fechas antes de comparar (convertirlas a UTC).
Qué cambia y por qué:
• Antes: comparación directa con ValidFrom/ValidTo podía fallar si esas fechas no estaban en UTC (p. ej. Kind = Unspecified o Local).
• Ahora: se usa ToUniversalTime() en ValidFrom y ValidTo para normalizar a UTC y comparar con DateTime.UtcNow. Esto evita discrepancias de zona horaria y hace la comprobación consistente tanto en ejecución como en depuración.
Verificación rápida:
• Añade temporalmente logs para imprimir ValidFrom, ValidFrom.Kind, ValidFrom.ToUniversalTime() y DateTime.UtcNow después de la autenticación para confirmar el comportamiento.