fix: generate Qwen commands as Markdown#1085
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughQwen command generation now produces Markdown (.md) files with YAML frontmatter instead of TOML, escapes descriptions for YAML, converts colon-style command refs to hyphen-style, exports a legacy TOML path helper, and removes obsolete Qwen TOML files during init and update flows. ChangesQwen TOML-to-Markdown Format Migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/core/command-generation/adapters/qwen.ts`:
- Around line 15-22: The escapeYamlValue function detects carriage returns in
the needsQuoting regex but only escapes line feeds; update the escape logic in
escapeYamlValue to also replace '\r' with '\\r' (in addition to existing
replacements of backslash, double-quote, and '\n') so carriage returns are
properly serialized; locate the function named escapeYamlValue and add a
.replace(/\r/g, '\\r') step in the escaped string pipeline.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1a8f0123-7645-49be-98d1-9a359e11d62c
📒 Files selected for processing (8)
docs/supported-tools.mdsrc/core/command-generation/adapters/qwen.tssrc/core/init.tssrc/core/update.tstest/core/command-generation/adapters.test.tstest/core/command-generation/registry.test.tstest/core/init.test.tstest/core/update.test.ts
Summary
/opsx:*to/opsx-*to match the flat command filenames.qwen/commands/opsx-*.tomlfiles during init/update so users do not keep stale TOML commands after upgradingFixes #838.
Validation
./node_modules/.bin/vitest run test/core/command-generation/adapters.test.ts test/core/command-generation/registry.test.ts test/core/init.test.ts test/core/update.test.ts test/core/legacy-cleanup.test.tsnode build.js./node_modules/.bin/eslint src/Full
./node_modules/.bin/vitest runwas also attempted: 1473 tests passed; 17 existing environment-sensitivezsh-installer.test.tscases failed locally because Oh My Zsh was detected under the test HOME.Generated with Codex using GPT-5.
Summary by CodeRabbit
New Features
Documentation
Tests