Skip to content

Add com.tivadar.best.socketio to embedded package build steps across all platforms#113

Merged
dyfios merged 2 commits into
mainfrom
copilot/add-socketio-plugin-copy-step
Apr 6, 2026
Merged

Add com.tivadar.best.socketio to embedded package build steps across all platforms#113
dyfios merged 2 commits into
mainfrom
copilot/add-socketio-plugin-copy-step

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 6, 2026

The build workflow copies Best plugins as embedded Unity packages but was missing com.tivadar.best.socketio (Best SocketIO), which needs to be included alongside the other Best packages.

Changes

  • Embedded package copy step — added com.tivadar.best.socketio to $embeddedPackages arrays (Windows Desktop, WebGL Compressed, WebGL Uncompressed, Android) and for pkg in loops (Mac, iOS)
  • Cleanup steps — added corresponding Remove-Item (PowerShell) and rm -rf (bash) cleanup entries for com.tivadar.best.socketio on all platforms
# PowerShell (Windows/Android)
$embeddedPackages = @("com.occasoftware.super-simple-skybox", "com.tivadar.best.http", "com.tivadar.best.mqtt", "com.tivadar.best.websockets", "com.tivadar.best.socketio")

# Bash (Mac/iOS)
for pkg in "com.occasoftware.super-simple-skybox" "com.tivadar.best.http" "com.tivadar.best.mqtt" "com.tivadar.best.websockets" "com.tivadar.best.socketio"; do

Copilot AI changed the title [WIP] Add Best SocketIO plugin copying step to the build workflow Add com.tivadar.best.socketio to embedded package build steps across all platforms Apr 6, 2026
Copilot AI requested a review from dyfios April 6, 2026 11:25
@dyfios dyfios marked this pull request as ready for review April 6, 2026 22:09
Copilot AI review requested due to automatic review settings April 6, 2026 22:09
@dyfios dyfios merged commit 9ab9188 into main Apr 6, 2026
2 of 3 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions runtime build workflow to embed the com.tivadar.best.socketio Unity package (Best SocketIO) alongside the other Best packages, ensuring it is copied into the project during builds and cleaned up afterward across all supported platforms.

Changes:

  • Added com.tivadar.best.socketio to the embedded package copy lists/loops for Windows Desktop, WebGL (compressed/uncompressed), Android, Mac, and iOS jobs.
  • Added corresponding cleanup removals (Remove-Item / rm -rf) for the embedded package on all platforms.
Comments suppressed due to low confidence (1)

.github/workflows/build-runtime.yml:159

  • In the embedded package copy loop, missing package directories are silently skipped (only copied if the source path exists). If these embedded packages are required for a correct build, consider failing the step (or at least logging a clear ::error::) when an expected package like com.tivadar.best.socketio is not found under UNITY_PACKAGES_PATH, to avoid producing builds without the intended embedded plugin.
          foreach ($pkg in $embeddedPackages) {
            $sourcePath = Join-Path $packagesPath $pkg
            $targetPath = Join-Path "$env:PROJECT_PATH\Packages" $pkg
            if (Test-Path $sourcePath) {
              if (Test-Path $targetPath) { Remove-Item -Recurse -Force $targetPath }
              New-Item -ItemType Directory -Path $targetPath -Force | Out-Null
              Copy-Item -Path "$sourcePath\*" -Destination $targetPath -Recurse -Force
              Write-Host "Copied $pkg"
            }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

$packagesPath = "$env:UNITY_PACKAGES_PATH"
if (-not (Test-Path $packagesPath)) { Write-Host "::error::Packages not found"; exit 1 }
$embeddedPackages = @("com.occasoftware.super-simple-skybox", "com.tivadar.best.http", "com.tivadar.best.mqtt", "com.tivadar.best.websockets")
$embeddedPackages = @("com.occasoftware.super-simple-skybox", "com.tivadar.best.http", "com.tivadar.best.mqtt", "com.tivadar.best.websockets", "com.tivadar.best.socketio")
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The embedded package list is duplicated across multiple jobs in this workflow (Windows/WebGL/Android PowerShell + Mac/iOS bash). Since this PR is fixing an omission caused by that duplication, consider centralizing the package list (e.g., YAML anchor or a single env var) so future package additions only need to be made in one place.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Best SocketIO plugin copying step to the build workflow

3 participants