Conversation
There was a problem hiding this comment.
Pull request overview
This PR targets a VR lighting issue in DesktopMode.EnableVR() by disabling HDR on the VR camera. However, the change is explicitly labeled as a temporary probe with a "Revert after test" directive, indicating it is exploratory debugging code rather than a finalized fix.
Changes:
- Sets
vrCamera.allowHDR = falsewhen VR mode is enabled. - Adds an inline comment marking the change as a temporary probe to be reverted after testing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public void EnableVR() | ||
| { | ||
| vrEnabled = true; | ||
| // PROBE: testing whether HDR output is a compounding cause of VR overbright. Revert after test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.