feat: removed hard-coded configuration parameters in preparation for automated client deployment by bakirFS · Pull Request #65 · Flagsmith/flagsmith-jira-integration

bakirFS · 2026-07-17T14:18:34Z

Contributes to #59

Created this PR to remove hard-coded variables from code which caused us to have bespoke deployments for each customer using private cloud.

I left old hard-coded values as defaults, so if you want to override them you need to provide values in github variables.
Those are: FLAGSMITH_BACKEND_HOST, FORGE_APP_ID, FLAGSMITH_APP and FLAGSMITH_API_V1.

Changes have been tested by providing invalid manifest variables (FLAGSMITH_BACKEND_HOST) which made the deployment fail and by providing invalid runtime variables (FLAGSMITH_API_V1) which deployed the app but not communicate with the API.

matthewelwell · 2026-07-21T09:13:20Z

+      # Manifest variables: substituted into manifest.yml by the Forge CLI from
+      # the shell at deploy time. Only override the SaaS defaults when provided.
+      - name: Set manifest variables
+        run: |
+          if [ -n "${{ vars.FORGE_APP_ID }}" ]; then
+            echo "FORGE_APP_ID=${{ vars.FORGE_APP_ID }}" >> "$GITHUB_ENV"
+          fi
+          if [ -n "${{ vars.FLAGSMITH_BACKEND_HOST }}" ]; then
+            echo "FLAGSMITH_BACKEND_HOST=${{ vars.FLAGSMITH_BACKEND_HOST }}" >> "$GITHUB_ENV"
+          fi
+      # Runtime variables: stored by Forge and read via process.env in functions.
+      # Set them when provided; otherwise unset any stale value so the code falls
+      # back to SaaS defaults. Unsetting is idempotent (|| true tolerates absence).
+      - name: Set runtime variables
+        run: |
+          if [ -n "${{ vars.FLAGSMITH_API_V1 }}" ]; then
+            forge variables set FLAGSMITH_API_V1 "${{ vars.FLAGSMITH_API_V1 }}" --environment ${{ inputs.environment }}
+          else
+            forge variables unset FLAGSMITH_API_V1 --environment ${{ inputs.environment }} || true
+          fi
+          if [ -n "${{ vars.FLAGSMITH_APP }}" ]; then
+            forge variables set FLAGSMITH_APP "${{ vars.FLAGSMITH_APP }}" --environment ${{ inputs.environment }}
+          else
+            forge variables unset FLAGSMITH_APP --environment ${{ inputs.environment }} || true
+          fi


Now, I do understand why we have this logic to verify if the values exists, but thinking about it logically this YAML file is only used by us for deploying to our SaaS environments, and these variables are all visible in the Github interface (since they're vars and not secrets) so I would suggest that this workflow shouldn't care about whether they exist or not.

Suggested change

# Manifest variables: substituted into manifest.yml by the Forge CLI from

# the shell at deploy time. Only override the SaaS defaults when provided.

- name: Set manifest variables

run: |

if [ -n "${{ vars.FORGE_APP_ID }}" ]; then

echo "FORGE_APP_ID=${{ vars.FORGE_APP_ID }}" >> "$GITHUB_ENV"

fi

if [ -n "${{ vars.FLAGSMITH_BACKEND_HOST }}" ]; then

echo "FLAGSMITH_BACKEND_HOST=${{ vars.FLAGSMITH_BACKEND_HOST }}" >> "$GITHUB_ENV"

fi

# Runtime variables: stored by Forge and read via process.env in functions.

# Set them when provided; otherwise unset any stale value so the code falls

# back to SaaS defaults. Unsetting is idempotent (|| true tolerates absence).

- name: Set runtime variables

run: |

if [ -n "${{ vars.FLAGSMITH_API_V1 }}" ]; then

forge variables set FLAGSMITH_API_V1 "${{ vars.FLAGSMITH_API_V1 }}" --environment ${{ inputs.environment }}

else

forge variables unset FLAGSMITH_API_V1 --environment ${{ inputs.environment }} || true

fi

if [ -n "${{ vars.FLAGSMITH_APP }}" ]; then

forge variables set FLAGSMITH_APP "${{ vars.FLAGSMITH_APP }}" --environment ${{ inputs.environment }}

else

forge variables unset FLAGSMITH_APP --environment ${{ inputs.environment }} || true

fi

# Manifest variables: substituted into manifest.yml by the Forge CLI from

# the shell at deploy time.

- name: Set manifest variables

run: |

echo "FORGE_APP_ID=${{ vars.FORGE_APP_ID }}" >> "$GITHUB_ENV"

echo "FLAGSMITH_BACKEND_HOST=${{ vars.FLAGSMITH_BACKEND_HOST }}" >> "$GITHUB_ENV"

# Runtime variables: stored by Forge and read via process.env in functions.

run: |

forge variables set FLAGSMITH_API_V1 "${{ vars.FLAGSMITH_API_V1 }}" --environment ${{ inputs.environment }}

forge variables set FLAGSMITH_APP "${{ vars.FLAGSMITH_APP }}" --environment ${{ inputs.environment }}

Not sure I understood you, did you mean I should remove the if statement since the values will always be set?

Confirmed in Slack - yes, that's what I mean.

matthewelwell · 2026-07-21T09:15:35Z

+  if (config === undefined) {
+    return <Spinner label="Loading feature flag state" />;
+  }


I'm not sure why config would ever be undefined? And if it were, why that would be temporary (and hence warrant a spinner)?

matthewelwell · 2026-07-21T09:19:02Z

+import { customInvoke } from "./invoke";
+export { Config } from "../backend/config";
+
+/** Read frontend-visible configuration from the backend resolver */


Reading across the frontend / backend separations feels a bit odd here - is there a way around this?

Prevents the encryption prompt from failing the deploy in CI's non-TTY environment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

switched to github variables, ready to test

be22bd5

bakirFS requested a review from a team as a code owner July 17, 2026 14:18

bakirFS requested review from talissoncosta and removed request for a team July 17, 2026 14:18

bakirFS temporarily deployed to development July 17, 2026 14:27 — with GitHub Actions Inactive

bakirFS temporarily deployed to development July 17, 2026 14:34 — with GitHub Actions Inactive

add deploy.yml

6f71b54

bakirFS had a problem deploying to development July 17, 2026 14:44 — with GitHub Actions Failure

bakirFS temporarily deployed to development July 17, 2026 14:48 — with GitHub Actions Inactive

bakirFS temporarily deployed to development July 17, 2026 14:53 — with GitHub Actions Inactive

bakirFS temporarily deployed to development July 17, 2026 15:19 — with GitHub Actions Inactive

bakirFS temporarily deployed to development July 17, 2026 15:27 — with GitHub Actions Inactive

bakirFS had a problem deploying to development July 17, 2026 15:41 — with GitHub Actions Error

bakirFS temporarily deployed to development July 17, 2026 15:42 — with GitHub Actions Inactive

bakirFS temporarily deployed to development July 17, 2026 15:47 — with GitHub Actions Inactive

bakirFS temporarily deployed to development July 17, 2026 15:52 — with GitHub Actions Inactive

bakirFS force-pushed the feat/switch-to-github-variables branch from 238d4f1 to 6f71b54 Compare July 17, 2026 16:01

bakirFS temporarily deployed to development July 17, 2026 16:01 — with GitHub Actions Inactive

bakirFS temporarily deployed to development July 20, 2026 10:53 — with GitHub Actions Inactive

bakirFS temporarily deployed to development July 20, 2026 11:04 — with GitHub Actions Inactive

added if statement to check for empty string

a0b57ac

bakirFS temporarily deployed to development July 20, 2026 11:17 — with GitHub Actions Inactive

changed ?? to ||

c3420a9

bakirFS temporarily deployed to development July 20, 2026 11:32 — with GitHub Actions Inactive

added forge unset to deploy.yml

e7089c6

bakirFS temporarily deployed to development July 20, 2026 12:26 — with GitHub Actions Inactive

bakirFS temporarily deployed to development July 20, 2026 12:31 — with GitHub Actions Inactive

bakirFS temporarily deployed to development July 20, 2026 12:36 — with GitHub Actions Inactive

bakirFS had a problem deploying to development July 20, 2026 12:57 — with GitHub Actions Failure

bakirFS deployed to development July 20, 2026 13:04 — with GitHub Actions Active

bakirFS requested review from matthewelwell and removed request for talissoncosta July 20, 2026 13:09

matthewelwell requested changes Jul 21, 2026

View reviewed changes

bakirFS added 4 commits July 23, 2026 13:38

working on pr

4e361d4

removed undefined check for config

c432712

restructured fe/be config

92a9954

removed set/unset forge variables

3059ca4

bakirFS had a problem deploying to development July 28, 2026 13:17 — with GitHub Actions Failure

add --non-interactive to forge variables set

6ab71c5

Prevents the encryption prompt from failing the deploy in CI's non-TTY environment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

bakirFS had a problem deploying to development July 28, 2026 15:27 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: removed hard-coded configuration parameters in preparation for automated client deployment - #65

feat: removed hard-coded configuration parameters in preparation for automated client deployment#65
bakirFS wants to merge 10 commits into
mainfrom
feat/switch-to-github-variables

bakirFS commented Jul 17, 2026 •

edited

Loading

Uh oh!

matthewelwell Jul 21, 2026

Uh oh!

bakirFS Jul 23, 2026

Uh oh!

matthewelwell Jul 27, 2026

Uh oh!

matthewelwell Jul 21, 2026

Uh oh!

matthewelwell Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

bakirFS commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthewelwell Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

bakirFS Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

matthewelwell Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

matthewelwell Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

matthewelwell Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bakirFS commented Jul 17, 2026 •

edited

Loading