Stellux posix cwd semantics#65
Merged
FlareCoding merged 7 commits intostellux-3.0-prototypingfrom Mar 4, 2026
Merged
Conversation
Co-authored-by: Albert Slepak <FlareCoding@users.noreply.github.com>
Co-authored-by: Albert Slepak <FlareCoding@users.noreply.github.com>
…ntics Co-authored-by: Albert Slepak <FlareCoding@users.noreply.github.com>
Co-authored-by: Albert Slepak <FlareCoding@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-authored-by: Albert Slepak <FlareCoding@users.noreply.github.com>
Co-authored-by: Albert Slepak <FlareCoding@users.noreply.github.com>
Co-authored-by: Albert Slepak <FlareCoding@users.noreply.github.com>
| return resolve_rc; | ||
| } | ||
| path_for_open = resolved_path; | ||
| } |
There was a problem hiding this comment.
SHM path check uses unnormalized path for absolute paths
Medium Severity · Security Issue
In do_open_common, when kpath is absolute, is_shm_path is checked against the raw unnormalized user path before normalizing. A path like /dev/shm/../../etc/passwd would pass the is_shm_path prefix check, then normalize_absolute_path resolves it to /etc/passwd, which is routed to resource::open as though it's an shm path. The relative-path branch correctly checks is_shm_path on the normalized path. The same issue exists in unlinkat for absolute shm paths.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement POSIX current working directory (CWD) semantics to enable relative path resolution and standard CWD syscalls.