feat(kernel): added PTY subsystem, proc_set_handle API, and reusable line discipline#66
Merged
FlareCoding merged 1 commit intostellux-3.0-prototypingfrom Mar 4, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches kernel resource/handle management and adds new syscalls and terminal I/O paths; bugs could cause handle leaks, incorrect rights propagation, or PTY/console read-write/close edge cases.
Overview
Adds a new PTY resource type and subsystem, including
pty_createsyscall to allocate a master/slave pair backed by ring buffers and a per-PTY line discipline (with cooked/raw mode and optional echo).Extends process management with
proc_set_handle, enabling callers to replace a specific handle slot in a CREATED child beforeproc_start, supported by new handle-table helpers (get_handle_objectcan return rights;install_handle_atreplaces an existing slot safely).Refactors console input handling into a reusable
terminal/line_disciplinemodule and updates the console terminal to use it; adds kernel PTY unit tests and a userlandptytestapp plus libstlx wrappers and syscall number definitions.Written by Cursor Bugbot for commit 9614e1f. This will update automatically on new commits. Configure here.