fix(plugin-record-hook): rethrow errors instead of swallowing them#874
Closed
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Closed
fix(plugin-record-hook): rethrow errors instead of swallowing them#874devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Previously, errors during record hook execution were caught, logged, and then silently swallowed by returning early. This caused issues where record updates could fail silently without surfacing the error to the execution status. Changes: - Rethrow errors in the outer catch block so they propagate to the listener runtime and mark executions as failed - Preserve the original error message when catching errors from event.update() for better debugging Co-Authored-By: christopher.harrison@flatfile.io <cnharrison@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
📝 Documentation updates detected! New suggestion: Add changelog entry for plugin-record-hook error propagation fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please explain how to summarize this PR for the Changelog:
fix(plugin-record-hook): Errors during record hook execution are now properly propagated instead of being silently swallowed. Previously, errors were logged but the function would return normally, causing executions to appear successful even when record updates failed.
Tell code reviewer how and what to test:
Context: This fix addresses an issue where bulk record hook updates could fail silently. When
event.update()failed, the error was caught, logged, and then the function returned without indicating failure. This caused agent executions to be marked as successful even when validation results weren't persisted.Changes:
returntothrow eso errors propagate to the listener runtimeReview checklist:
@flatfile/listener'sAuthenticatedClient.fetch()which swallows errors. This fix helps surface errors that DO get thrown, but won't catch cases wherefetch()silently returnsundefinedTo test:
event.update()(e.g., network error, invalid data)Requested by: christopher.harrison@flatfile.io (@cnharrison)