Dev#10
Merged
Merged
Conversation
# Conflicts: # Cargo.toml
# Conflicts: # Cargo.lock # Cargo.toml # src/results.rs
Merged
coco875
requested changes
Feb 2, 2026
coco875
left a comment
coco875
left a comment
Contributor
There was a problem hiding this comment.
mostly look good, just avoid to duplicate struct
|
|
||
| /// An item that can be held or placed in a slot | ||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| pub struct Item { |
Contributor
There was a problem hiding this comment.
already define in test_specs
|
|
||
| /// Block data returned from get_block | ||
| #[derive(Debug, Clone, PartialEq, Eq, Serialize)] | ||
| pub struct BlockData { |
Contributor
There was a problem hiding this comment.
already define in test_specs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the #9 PR and flint-steel which is more an abstracted flint-lib version