Refactor: 협업시 인증 추가#11
Merged
stoneTiger0912 merged 4 commits intomainfrom Apr 2, 2026
Merged
Conversation
|
Caution Review failedPull request was closed or merged during review 워크스루WebSocket 인증을 gRPC 기반 토큰 검증으로 변경하고, 협업 게이트웨이에 관리자 권한 검증을 추가했습니다. 변경 사항
시퀀스 다이어그램sequenceDiagram
participant Client
participant Gateway as Collaboration Gateway
participant UseCase as CollaborationUseCase
participant GrpcClient as UserGrpcClient
participant Repo as CardsetManager Repo
Client->>Gateway: join-cardset 이벤트 (cardsetId, token)
activate Gateway
Gateway->>UseCase: isManager(cardsetId, userId)
activate UseCase
UseCase->>Repo: findOne({cardSetId, userId})
activate Repo
Repo-->>UseCase: 관리자 레코드 또는 null
deactivate Repo
UseCase-->>Gateway: boolean (true/false)
deactivate UseCase
alt 관리자 확인
Gateway->>Client: 협업 문서 동기화 계속
else 관리자 아님
Gateway->>Gateway: 경고 로그
Gateway->>Client: error 이벤트 (권한 없음)
Gateway-->>Client: 조인 실패
end
deactivate Gateway
예상 코드 리뷰 노력🎯 4 (복잡함) | ⏱️ ~50분 관련 가능성이 있는 PR
시
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 변경 내용
✅ 체크리스트
💬 기타 참고 사항
Summary by CodeRabbit
릴리스 노트
새 기능
개선 사항