Skip to content

Improve ImageLoader thumbnail fallbacks and refactor GetThumbnailResult #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidGBrett merged 18 commits into from
Jun 7, 2026
Merged

Improve ImageLoader thumbnail fallbacks and refactor GetThumbnailResult #4453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
14d51b0
Fallback to ExtractAssociatedIcon if GetThumbnail fails on non image/…
DavidGBrett May 10, 2026
847d530
Extract bitmap image loading logic to a reusable method
DavidGBrett May 10, 2026
276be3b
Rename LoadFullImage to LoadBitmapImageScaleToFitWithin and add max s…
DavidGBrett May 10, 2026
baeaaa9
Fallback to loading the bitmap image at small size if GetThumbnail fails
DavidGBrett May 10, 2026
e395fcc
Fallback to default folder icon if GetThumbnail fails on folders
DavidGBrett May 10, 2026
e77b6e8
Refactor GetThumbnailResult by extracting branch cases into helper me…
DavidGBrett May 10, 2026
e2ee779
Consistently use MissingImage instead of generic Image for missing th…
DavidGBrett May 10, 2026
4989f89
Make directory fallback to folder icon also modify path to it
DavidGBrett May 10, 2026
34b217c
Remove unused ImageIcon constant
DavidGBrett May 11, 2026
74154f0
Fix bitmap image scaling to fit logic
DavidGBrett May 11, 2026
e3fa2a4
Refactor ImageLoader to remove path mutation side effects
DavidGBrett May 11, 2026
a4181ca
Add and use TryGetBitmapImageDimensionsFromMetadata to avoid unnecess…
DavidGBrett May 13, 2026
d989b2e
Use better Log levels and improve messages in ImageLoader
DavidGBrett May 15, 2026
209fcd2
Make GetDirectoryThumbnailResult take loadFullImage flag like the oth…
DavidGBrett May 15, 2026
130b729
Replace ExtractAssociatedIconOrNull with TryExtractAssociatedIcon
DavidGBrett May 16, 2026
fc263dc
Add ThumbnailLoader delegate for GetThumbnail testability
DavidGBrett May 23, 2026
6c97308
Add test suite for ImageLoader
DavidGBrett May 23, 2026
ccda60a
Rename GetThumbnail to GetShellThumbnail and the same to derived vari…
DavidGBrett May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Flow.Launcher.Infrastructure/Constant.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ public static class Constant
public static readonly string ErrorIcon = Path.Combine(ImagesDirectory, "app_error.png");
public static readonly string MissingImgIcon = Path.Combine(ImagesDirectory, "app_missing_img.png");
public static readonly string LoadingImgIcon = Path.Combine(ImagesDirectory, "loading.png");
public static readonly string ImageIcon = Path.Combine(ImagesDirectory, "image.png");
public static readonly string HistoryIcon = Path.Combine(ImagesDirectory, "history.png");
public static readonly string SettingsIcon = Path.Combine(ImagesDirectory, "settings.png");
public static readonly string FolderIcon = Path.Combine(ImagesDirectory, "folder.png");

public static string PythonPath;
public static string NodePath;
Expand Down
Loading
Loading