-
-
Notifications
You must be signed in to change notification settings - Fork 622
Add flow-launcher:// deep link protocol, .flowplugin file association, and --query command line argument #4565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Garulf
wants to merge
10
commits into
dev
Choose a base branch
from
feature/query-command-line-arg
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
27d911c
Add --query command line argument to open Flow Launcher with a query
Garulf cb73cd8
Add DeepLink parser and command line normalization with tests
Garulf 8574152
Add HKCU registration helper for .flowplugin and flow-launcher:// scheme
Garulf e8eb0c7
Add PluginInstaller method to install a plugin from a web url
Garulf bcc24fe
Add deep link verb dispatch for query, settings and plugin install
Garulf 02396e1
Route command line args through deep link dispatch and register handl…
Garulf 19a98fc
Add settings toggle for the flow-launcher:// URI scheme
Garulf eb1c876
Address review findings: async pipe activation, manifest error handli…
Garulf da750b0
Address second round of PR review findings
Garulf ab882e6
Fix single-instance signal timeout budget and log genuine pipe read f…
Garulf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| using System; | ||
| using Flow.Launcher.Helper; | ||
| using NUnit.Framework; | ||
|
|
||
| namespace Flow.Launcher.Test | ||
| { | ||
| [TestFixture] | ||
| public class DeepLinkTest | ||
| { | ||
| [Test] | ||
| public void FromCommandLineArgs_QueryFlag_NormalizesToQueryUri() | ||
| { | ||
| var result = DeepLink.FromCommandLineArgs(new[] { "--query", "foo bar" }, true); | ||
| Assert.That(result, Is.EqualTo("flow-launcher://query?q=foo%20bar")); | ||
| } | ||
|
|
||
| [Test] | ||
| public void FromCommandLineArgs_SingleDashQueryFlag_NormalizesToQueryUri() | ||
| { | ||
| var result = DeepLink.FromCommandLineArgs(new[] { "-q", "foo" }, true); | ||
| Assert.That(result, Is.EqualTo("flow-launcher://query?q=foo")); | ||
| } | ||
|
|
||
| [Test] | ||
| public void FromCommandLineArgs_FlowPluginPath_NormalizesToInstallUri() | ||
| { | ||
| var path = OperatingSystem.IsWindows() ? @"C:\tmp\My Plugin.flowplugin" : "/tmp/My Plugin.flowplugin"; | ||
| var result = DeepLink.FromCommandLineArgs(new[] { path }, true); | ||
| Assert.That(result, Does.StartWith("flow-launcher://plugin/install?path=")); | ||
| Assert.That(Uri.UnescapeDataString(result.Split("path=")[1]), Does.EndWith("My Plugin.flowplugin")); | ||
| } | ||
|
|
||
| [Test] | ||
| public void FromCommandLineArgs_RawSchemeUri_PassedThroughWhenAllowed() | ||
| { | ||
| var result = DeepLink.FromCommandLineArgs(new[] { "flow-launcher://settings" }, true); | ||
| Assert.That(result, Is.EqualTo("flow-launcher://settings")); | ||
| } | ||
|
|
||
| [Test] | ||
| public void FromCommandLineArgs_RawSchemeUri_DroppedWhenDisallowed() | ||
| { | ||
| var result = DeepLink.FromCommandLineArgs(new[] { "flow-launcher://settings" }, false); | ||
| Assert.That(result, Is.Null); | ||
| } | ||
|
|
||
| [Test] | ||
| public void FromCommandLineArgs_FlowPluginPath_StillWorksWhenSchemeDisallowed() | ||
| { | ||
| var result = DeepLink.FromCommandLineArgs(new[] { "plugin.flowplugin" }, false); | ||
| Assert.That(result, Does.StartWith("flow-launcher://plugin/install?path=")); | ||
| } | ||
|
|
||
| [Test] | ||
| public void FromCommandLineArgs_NoRelevantArgs_ReturnsNull() | ||
| { | ||
| Assert.That(DeepLink.FromCommandLineArgs(Array.Empty<string>(), true), Is.Null); | ||
| Assert.That(DeepLink.FromCommandLineArgs(new[] { "--unrelated" }, true), Is.Null); | ||
| Assert.That(DeepLink.FromCommandLineArgs(new[] { "--query" }, true), Is.Null); // flag without value | ||
| } | ||
|
|
||
| [Test] | ||
| public void FromCommandLineArgs_QueryFlagWithEmptyValue_ReturnsNull() | ||
| { | ||
| Assert.That(DeepLink.FromCommandLineArgs(new[] { "--query", "" }, true), Is.Null); | ||
| Assert.That(DeepLink.FromCommandLineArgs(new[] { "-q", "" }, true), Is.Null); | ||
| } | ||
|
|
||
| [TestCase("flow-launcher://query?q=hello%20world", "query", "q", "hello world")] | ||
| [TestCase("flow-launcher://plugin/install?id=abc123", "plugin/install", "id", "abc123")] | ||
| [TestCase("FLOW-LAUNCHER://SETTINGS", "settings", null, null)] | ||
| public void TryParse_ValidUris_ExtractsVerbAndParameters(string payload, string expectedVerb, string paramKey, string paramValue) | ||
| { | ||
| var ok = DeepLink.TryParse(payload, out var verb, out var parameters); | ||
| Assert.That(ok, Is.True); | ||
| Assert.That(verb, Is.EqualTo(expectedVerb)); | ||
| if (paramKey != null) | ||
| Assert.That(parameters[paramKey], Is.EqualTo(paramValue)); | ||
| } | ||
|
|
||
| [TestCase(null)] | ||
| [TestCase("")] | ||
| [TestCase("just a plain query string")] | ||
| [TestCase("https://example.com/notourscheme")] | ||
| public void TryParse_InvalidPayloads_ReturnsFalse(string payload) | ||
| { | ||
| Assert.That(DeepLink.TryParse(payload, out _, out _), Is.False); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Installing a plugin from a web URL can produce an empty or misleading plugin name when the URL path contains percent-encoded characters that decode to invalid Windows filename characters (e.g.,
%3F→?). AfterPath.GetFileNameand the invalid-character stripping loop, a basename like?.zipcollapses to.zip, and removing the extension yields an empty string. That empty value flows intoUserPlugin.NameandVersion, so user-facing prompts show a blank plugin name, and the temp download filename becomes-$'{Guid.NewGuid()}.zip. Consider validating the sanitized result and falling back to a safe default (for example,"plugin"or the last non-empty path segment) before constructing theUserPlugin.Prompt for AI agents