fix: atomic restore write and pid-qualified temp file#23
Conversation
restoreAndroidYaml now uses the same temp-file+rename atomic write as the stamp path (a failed restore previously could truncate the config), and the temp filename is pid-qualified so parallel release builds in one worktree cannot clobber each other. Also syncs the review workflow with main's severity-classified version.
Review: fix — atomic restore write and pid-qualified temp fileNo Critical issues. The refactor is correct and both tabled items from PR #19 are properly addressed. What the PR does
FindingsMedium — No tests added for the new atomic restore behaviour. Low — Workflow YAML
|
|
Triage: no Critical findings. Tabling the Medium (unit test for the atomic-restore invariant — stub a failing |
Closes out the checkpoint-lineage items tabled (Medium/Low) from the PR #19 reviews:
restoreAndroidYamlnow uses the same temp-file+rename pattern as the stamp write — a failed restore previously wrote in place and could truncate the config, a worse outcome than the stamped state.fcp codepush releaseruns in one worktree (e.g. a CI matrix building apk and appbundle) no longer collide on the temp filename.Also syncs
.github/workflows/claude-review.ymlwith main's severity-classified sticky-comment version so this lineage's PRs are reviewed under the same policy.