feat: add GOKAPI_AWS_PROXY_DOWNLOAD environment variable#372
Merged
Forceu merged 2 commits intoForceu:masterfrom Mar 1, 2026
Merged
feat: add GOKAPI_AWS_PROXY_DOWNLOAD environment variable#372Forceu merged 2 commits intoForceu:masterfrom
GOKAPI_AWS_PROXY_DOWNLOAD environment variable#372Forceu merged 2 commits intoForceu:masterfrom
Conversation
Contributor
Author
|
this may be partially related to #332 |
Owner
|
Thank you very much, I noticed that a couple of hours ago as well and was just about to implement this :D |
Contributor
Author
|
Sorry for flooding you with PRs |
Owner
|
No worries, I am grateful for every PR! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
loadFromEnv()did not includeProxyDownload, so it always defaulted tofalsewhen AWS credentials were provided via environment variables.This PR wires it into
loadFromEnv()and restoresGOKAPI_AWS_PROXY_DOWNLOAD(removed in eff0448).Type of Change
Technical Details
How Has This Been Tested?
go test -tags test ./internal/environment/... ./internal/configuration/cloudconfig/... ./internal/configuration/setup/...Checklist