Open
Conversation
29b58b1 to
c8630b8
Compare
Contributor
Author
|
Just checking in, I know it's been a while. Can you give me any feedback on the provided change? |
Owner
|
Hi, sorry for the very late reply. Unfortunately I did not have a lot of time recently, but I will have a look at it in the next days! |
Forceu
requested changes
Aug 14, 2021
Owner
Forceu
left a comment
There was a problem hiding this comment.
When clicking on "Consume All" I get the following error:
PHP message: PHP Fatal error: Uncaught TypeError: Argument 1 passed to {closure}() must be of the type int, string given in /app/bbuddy/index.php:215
Stack trace:
#0 [internal function]: {closure}('Consume all', 'button_consume_...')
#1 /app/bbuddy/index.php(217): array_filter(Array, Object(Closure), 1)
#2 /app/bbuddy/index.php(99): processButtons()
#3 {main}
Also please adjust the buttons to make them look a little bit less out of place, maybe the best way to do that would be to put them into the overflow menu where the "Delete All" option is as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I've been wanting to add those for a while now. When there's at least one product in the list of known/unknown barcodes, the UI will display additional buttons to add or consume all products that have been assigned a Grocy id. This allows me to quickly assign products without having to click the regular Add/Consume buttons all the time and waiting for the page to reload.
I've added a check to only update products that have anything other than == None == selected in the product field.
Let me know what you think (or if there's anything I should do differently UI-wise). Also let me know if this feature already exists and I'm just too dumb to use it ;)
Cheers
Philipp