Fix BBUDDY_EXTERNAL_GROCY_URL env var being ignored#291
Open
goto1134 wants to merge 5 commits intoForceu:masterfrom
Open
Fix BBUDDY_EXTERNAL_GROCY_URL env var being ignored#291goto1134 wants to merge 5 commits intoForceu:masterfrom
goto1134 wants to merge 5 commits intoForceu:masterfrom
Conversation
…eu#230 convertCorrectType() was casting env var values to match the type of the default config value. For EXTERNAL_GROCY_URL (default: null), this meant settype($result, "NULL") converted any string value back to null, effectively discarding the env var. Return the value directly when the original config default is null. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BBUDDY_EXTERNAL_GROCY_URLenvironment variable was silently discarded, causing the Grocy header link to always show the internal API URL instead of the configured external URL.convertCorrectType()cast env var values to match the default config type. SinceEXTERNAL_GROCY_URLdefaults tonull,settype($result, "NULL")converted any string value back tonull.null, return the string value directly (after boolean conversion) instead of attempting a type cast toNULL.convertCorrectType()covering null, string, integer, boolean, and array conversions.Notes
nikic/php-parserversion bumped from4.12.0to^4.19.1to resolve dependency conflicts with PHPUnit 9.🤖 Generated with Claude Code