Merged
Conversation
Owner
Author
|
Let's merge this in to reduce the diff on #52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Following on the recently added a "Private" checkbox (allowing users to mark individual messages as ephemeral/session-only) which is implemented by ChatInterface.tsx skiping calling conversation State.addMessage() for private messages, preventing them from being saved.
However, relying solely on UI-layer filtering is fragile : bugs, refactoring, or edge cases could cause private messages to leak into the persistence layer.
Problem
Private messages (marked with isPrivate: true) must NEVER be persisted to IndexedDB or synced to the server. They should only exist in app state during the current session and disappear on refresh.
Solution
Implement defense-in-depth filtering at the persistence layer to guarantee private messages are never saved, regardless of what happens upstream.
Changes Made
src/services/indexedDbStorage.tsIf filtering results in zero messages (all were private), delete the conversation from:
Prevents empty conversations from cluttering the sidebar 🚀!!!
Expected Behavior
Architecture
Two-layer defense:
NB: PR addresses multiple issues
src/__tests__/services/mcpService.test.ts