[OU-ADD] stock: tests#27
Merged
MiquelRForgeFlow merged 1 commit intoForgeFlow:18.0-fix-stockfrom Jun 10, 2025
Merged
Conversation
Author
|
that's expected, these tests are assertions how the migration should behave in my opinion, not how it currently behaves. see todos in the test code |
MiquelRForgeFlow
approved these changes
Jun 10, 2025
MiquelRForgeFlow
left a comment
There was a problem hiding this comment.
Thanks, I hope your tests are correct, if not it will be a mess.
7f93189
into
ForgeFlow:18.0-fix-stock
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I think it's helpful to first fix the desired behavior post migration, and then look into how to achieve this. I've added a couple of tests here that fail, let's take it from there.
My suggestion would be: